Deployment should only work on pushing of certain tags?

[ronaldtse]

Right now, pushing any tag will result in deployment. However, we probably only want pushing a certain type of tag, e.g. 'v1.0' to trigger deployment? If someone pushes an old tag, the deployment will happen as well and that is not desired.

bibxml-service/.github/workflows/main.yml

Line 6 in 131d6f7

- '*'

[strogonoff]

I support this, this helps avoid situations where someone pushes a change but forgets to increment version. Version is shown in GUI and people may rely on it in some cases, so it’s undesirable.

[strogonoff]

relaton-py does it this way, but this service doesn’t use the v prefix for tags.

[strogonoff]

One problem here is that I don’t think Git tags are included in the PR. This creates a situation where we may have different version numbers on staging and production.

[strogonoff]

edit: Which may be OK? Given our versions are essentially dates.