Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CRUD-dedicated JS only applicable to heartbeat CRUD pages #5

Open
3 tasks
igorrosenberg opened this issue Feb 21, 2018 · 0 comments
Open
3 tasks
Labels
easy good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@igorrosenberg
Copy link
Owner

Difficulty

Easy

Where

In javascript: search for $('.test.button').click.

Problem

Reach of JS functions must be encapsulated. Ideally, it must be impossible to apply HeartBeat-related JS code to DOM nodes outside of the plugin

Proposal

As a first approach, limit the JS function to the heartbeat CRUD, via a CSS selector.

Subtasks:

  • which CSS selector?
  • modify CRUD GSP to match CSS selector
  • wire JS to CSS selector
@igorrosenberg igorrosenberg added this to the 3.0 milestone Feb 21, 2018
@igorrosenberg igorrosenberg added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 21, 2018
@igorrosenberg igorrosenberg changed the title (easy) make CRUD-dedicated JS only applicable to heartbeat CRUD pages Make CRUD-dedicated JS only applicable to heartbeat CRUD pages Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant