Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Test" button does not show http 500 when it Occurs within the "show" view. #6

Open
2 tasks
igorrosenberg opened this issue Feb 21, 2018 · 0 comments
Open
2 tasks
Labels
bug Something isn't working easy good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@igorrosenberg
Copy link
Owner

Difficulty

Easy

Where

‘show.gsp‘

Problem

Within the show.gsp view, which lets a user read the config of a HeartBeat, a "Test" button exists. It will triger a call to the server, and render the data retrieved in a dedicated HTML zone. But when an error occurs (for exemple, http 500), the error is not shown to the user: the error is silent!

Proposal

Use the HTML result zone to display the error.

The JS logic to do exactly that works in the _heartbeat.gsp.

Subtasks:

  • understand the difference in _heartbeat.gsp vs 'show.gsp' which breaks the error rendering.
  • fix rendering, so the error appears.
@igorrosenberg igorrosenberg added this to the 3.0 milestone Feb 21, 2018
@igorrosenberg igorrosenberg added help wanted Extra attention is needed good first issue Good for newcomers bug Something isn't working easy labels Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant