You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello there 👋 This looks really useful, thanks for making it. I wanted to try it out and noticed that there are no requirements specified in setup.py, which led to an error on import because requests was not installed.
I imagine that this is because you're only using packages that are used by jupyter. In my case I have jupyterlab installed in the base conda environment and multiple kernels installed in other environments. I only need ipykernel installed in the analysis env, so I didn't have requests.
It should be relatively straightforward to add the needed requirements to setup.py (I think just requests and ipython?). I can write a PR if you want
The text was updated successfully, but these errors were encountered:
Why would ipython be needed? I am not really a python developer much less ipython, I assumed that would be available in any environment the notebook would be used.
Why would ipython be needed? I am not really a python developer much less ipython, I assumed that would be available in any environment the notebook would be used.
Yeah, I assume so too. But it does get imported, and it seemed silly to add one requirement but not the other. It should be harmless to include, since pip will just see that it's already present.
Hello there 👋 This looks really useful, thanks for making it. I wanted to try it out and noticed that there are no requirements specified in
setup.py
, which led to an error on import becauserequests
was not installed.I imagine that this is because you're only using packages that are used by jupyter. In my case I have
jupyterlab
installed in the base conda environment and multiple kernels installed in other environments. I only needipykernel
installed in the analysis env, so I didn't haverequests
.It should be relatively straightforward to add the needed requirements to
setup.py
(I think justrequests
andipython
?). I can write a PR if you wantThe text was updated successfully, but these errors were encountered: