Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing requirements #16

Closed
jamestwebber opened this issue Jan 10, 2023 · 2 comments · Fixed by #17
Closed

missing requirements #16

jamestwebber opened this issue Jan 10, 2023 · 2 comments · Fixed by #17

Comments

@jamestwebber
Copy link
Contributor

Hello there 👋 This looks really useful, thanks for making it. I wanted to try it out and noticed that there are no requirements specified in setup.py, which led to an error on import because requests was not installed.

I imagine that this is because you're only using packages that are used by jupyter. In my case I have jupyterlab installed in the base conda environment and multiple kernels installed in other environments. I only need ipykernel installed in the analysis env, so I didn't have requests.

It should be relatively straightforward to add the needed requirements to setup.py (I think just requests and ipython?). I can write a PR if you want

@jrobinso
Copy link
Contributor

Thanks, if you can do a PR great.

Why would ipython be needed? I am not really a python developer much less ipython, I assumed that would be available in any environment the notebook would be used.

@jamestwebber
Copy link
Contributor Author

Why would ipython be needed? I am not really a python developer much less ipython, I assumed that would be available in any environment the notebook would be used.

Yeah, I assume so too. But it does get imported, and it seemed silly to add one requirement but not the other. It should be harmless to include, since pip will just see that it's already present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants