Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

role= attribute with comma? #111

Open
sydb opened this issue Aug 20, 2021 · 1 comment
Open

role= attribute with comma? #111

sydb opened this issue Aug 20, 2021 · 1 comment

Comments

@sydb
Copy link

sydb commented Aug 20, 2021

In MIX-People.xml there are 2 @role values of "speaker, collaborator"; in MIX-Lexicon-TEI-Dict.xml there are 2 @role values of "speaker collaborator" (and 1 of "editor researcher").

The Lexicon file is correct. Because COMMA (U+002C, ‘,’) is (unwisely IMHO) a legal character in teidata.word, and thus in teidata.enumerated, this is not a validity error. But since the values of @role are space-separated, in MIX-People.xml the two roles are “collaborator” and “speaker,”.

The following (untested) ODD snippet would allow this (and all sorts of other @role errors) to be caught in the initial validation phase.

	<elementSpec ident="person" module="namesdates" mode="change">
	  <attList>
	    <attDef ident="role" mode="change">
	      <valList type="closed">
		<valItem ident="speaker"/>
		<valItem ident="collaborator"/>
		<valItem ident="editor"/>
		<valItem ident="researcher"/> 
		<valItem ident="expert"/>
	      </valList>
	    </attDef>
	  </attList>
	</elementSpec>
@iljackb
Copy link
Owner

iljackb commented Aug 20, 2021

Hey Sid, Thanks for the feedback! I haven't had time to work on this lately, but I'll adjust the documents and add this to the ODD also. The ODD has quite a bit of work to be done on it actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants