Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucketing Time splits requires floorable Duration #180

Open
adrianmroz opened this issue Jan 15, 2019 · 0 comments
Open

Bucketing Time splits requires floorable Duration #180

adrianmroz opened this issue Jan 15, 2019 · 0 comments

Comments

@adrianmroz
Copy link

Hi!

When creating bucketing action for time splits, there's check for floorability of Duration: https://github.com/implydata/plywood/blob/master/src/expressions/timeBucketExpression.ts#L47

So some more interesting Durations are of the limits (P2D for example). We had generated Druid query with floorable Duration, changed Duration value inside query and send it to Druid - it worked fine.

Is it possible to loosen this requirement if Druid could support it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant