Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover coverage upload to codecov #210

Closed
NelsonVides opened this issue Sep 23, 2024 · 1 comment · Fixed by #212
Closed

Recover coverage upload to codecov #210

NelsonVides opened this issue Sep 23, 2024 · 1 comment · Fixed by #212

Comments

@NelsonVides
Copy link
Collaborator

As raised at #208 (comment), codecov uploads are not working, we need to update codecov action version to v4, configure a token in codecov, and add the token to the github actions secrets.

See https://github.com/codecov/codecov-action?tab=readme-ov-file#usage for details.
@NelsonVides NelsonVides mentioned this issue Sep 23, 2024
Merged
Open
@elbrujohalcon
Copy link
Member

I was not aware that codecov is a paid service. I'll just remove it from our code.

elbrujohalcon added a commit that referenced this issue Oct 30, 2024
@elbrujohalcon
Merge pull request #211 from inaka/brujo-210-codecov
61c505c 
Fix #210: Remove codecov integration
@elbrujohalcon elbrujohalcon reopened this Nov 8, 2024
@elbrujohalcon elbrujohalcon mentioned this issue Nov 8, 2024
Merged
elbrujohalcon added a commit that referenced this issue Nov 8, 2024
@elbrujohalcon
Merge pull request #212 from inaka/revert-211-brujo-210-codecov
dc8b96c 
Fix #210: Update codecov options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #210: Update codecov options inaka/worker_pool
2 participants
@elbrujohalcon @NelsonVides