Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt get_ functions for use by OpenCPU #24

Closed
34 of 45 tasks
PietrH opened this issue Jun 9, 2023 · 1 comment · Fixed by #23 or #30
Closed
34 of 45 tasks

Adapt get_ functions for use by OpenCPU #24

PietrH opened this issue Jun 9, 2023 · 1 comment · Fixed by #23 or #30
Assignees
Labels
enhancement New feature or request

Comments

@PietrH
Copy link
Member

PietrH commented Jun 9, 2023

TODO

Adapt functions:

  • get_acoustic_deployments()
  • get_acoustic_projects()
  • get_acoustic_receivers()
  • get_animal_projects()
  • list_deployment_ids()
  • get_animals()
  • get_cpod_projects()
  • get_tags()

Adapt tests:

  • get_acoustic_deployments()
  • get_acoustic_projects()
  • get_acoustic_receivers()
  • get_animal_projects()
  • list_deployment_ids()
  • get_animals()
  • get_cpod_projects()
  • get_tags()

Pass tests:

  • get_acoustic_deployments()
  • get_acoustic_projects()
  • get_acoustic_receivers()
  • get_animal_projects()
  • list_deployment_ids()
  • get_animals()
  • get_cpod_projects()
  • get_tags()

Add postman tests:

  • get_acoustic_deployments()
  • get_acoustic_projects()
  • get_acoustic_receivers()
  • get_animal_projects()
  • list_deployment_ids()
  • get_animals()
  • get_cpod_projects()
  • get_tags()

Expand postman tests with response content test:

  • get_acoustic_deployments()
  • get_acoustic_projects()
  • get_acoustic_receivers()
  • get_animal_projects()
  • list_deployment_ids()
  • get_animals()
  • get_cpod_projects()
  • get_tags()

  • pass tests vliz rstudio
  • pass R CMD CHECK

  • check postman test results
  • export postman tests
  • commit postman tests to repo using handy tool
@PietrH PietrH added the enhancement New feature or request label Jun 9, 2023
@PietrH PietrH self-assigned this Jun 9, 2023
@PietrH
Copy link
Member Author

PietrH commented Jun 9, 2023

tests regarding bad connections will fail because I haven't written a new failstate yet, eg. :

test_that("get_acoustic_deployments() returns error for incorrect connection", {
  expect_error(
    get_acoustic_deployments(credentials = "not_a_credentials"),
    "Not a credentials object to database."
  )
})

See #12

@PietrH PietrH linked a pull request Jun 9, 2023 that will close this issue
30 tasks
@PietrH PietrH closed this as completed in #23 Jun 9, 2023
@PietrH PietrH reopened this Jun 9, 2023
@PietrH PietrH linked a pull request Jun 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant