Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings when running the test suite #61

Open
niconoe opened this issue Feb 28, 2020 · 1 comment
Open

Warnings when running the test suite #61

niconoe opened this issue Feb 28, 2020 · 1 comment
Assignees

Comments

@niconoe
Copy link
Contributor

niconoe commented Feb 28, 2020

  • pywhip version: 0.3.3
  • Python version: 3.7 (via Anaconda)
  • Operating System: Mac OS

Description

Got a ton (147) of warnings when running the test suite. Fortunately, most of them are identical:

tests/test_validators.py::TestRequiredValidator::test_required_term
  /Users/nicolas_noe/pywhip/tests/test_validators.py:1530: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
    schema = yaml.load(self.yaml_multiple_term)

What I Did

$ python setup.py test
@niconoe niconoe self-assigned this Feb 28, 2020
@niconoe
Copy link
Contributor Author

niconoe commented Mar 4, 2020

Update: fixed the warnings related to YAML loading.

Next steps: also fix the "invalid escape sequence" warnings. Some are due to regexp that don't use raw strings, but others are more difficult to debut since pytest doesn't give location:

<unknown>:1
<unknown>:1
<unknown>:1
<unknown>:1
<unknown>:1
<unknown>:1
<unknown>:1
<unknown>:1
  <unknown>:1: DeprecationWarning: invalid escape sequence \?

Another next step: check if examples and documentation should also be updated to avoid YAML warnings (basically, add a parameter to each yaml.load() call: Loader=yaml.FullLoader)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant