Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New variant needed in the enum of commitment_proof #1945

Closed
livelybug opened this issue Mar 9, 2022 · 2 comments
Closed

New variant needed in the enum of commitment_proof #1945

livelybug opened this issue Mar 9, 2022 · 2 comments
Assignees
@adizere
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR E: non-cosmos External: related to non-Cosmos chains E: substrate External: substrate integration, requirements & problems I: dependencies Internal: related to dependencies
Milestone
Modules

Comments

@livelybug
Copy link

Hello,

The CommitmentProof has 4 variants Exist, Nonexist, Batch, Compressed, none of them matches the structure of the corresponding proof in Substrate.

We use a temporary work-around compose_ibc_merkle_proof to insert the Substrate's proof into the CommitmentProof currently.

Is it possible to create a new variant in CommitmentProof for Substrate?

Thank you
@andynog andynog added the E: non-cosmos External: related to non-Cosmos chains label Mar 9, 2022
@adizere
Copy link
Member

adizere commented Mar 10, 2022

I think it's possible. Changes to CommitmentProof would ideally go via this repo: https://github.com/confio/ics23/tree/master/rust upstream, then we'll update our dependency and the needed modifications will be available in ibc-rs also. Would you mind flagging the issue and motivation for the chance on ics23 repo?

@adizere adizere added the I: dependencies Internal: related to dependencies label Mar 10, 2022
@adizere adizere self-assigned this Mar 10, 2022
@adizere adizere added this to the v1.0.0 milestone Mar 10, 2022
@adizere adizere moved this to Backlog in IBC-rs: the road to v1 Mar 10, 2022
@livelybug
Copy link
Author

Thanks, it's flagged in cosmos/ics23#80

@romac romac added the A: blocked Admin: blocked by another (internal/external) issue or PR label Mar 14, 2022
@romac romac changed the title new variant needed in the enum of commitment_proof New variant needed in the enum of commitment_proof May 19, 2022
@romac romac added the E: substrate External: substrate integration, requirements & problems label May 19, 2022
@adizere adizere modified the milestones: v1.0.0, modules/v0.16 May 24, 2022
Repository owner moved this from Backlog to Closed in IBC-rs: the road to v1 Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

Labels
A: blocked Admin: blocked by another (internal/external) issue or PR E: non-cosmos External: related to non-Cosmos chains E: substrate External: substrate integration, requirements & problems I: dependencies Internal: related to dependencies
Projects
No open projects
IBC-rs: the road to v1
Status: Closed
Milestone
Modules
Development

No branches or pull requests
5 participants
@romac @adizere @hu55a1n1 @livelybug @andynog