Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code: Rework vote extensions #717

Open
romac opened this issue Dec 19, 2024 · 1 comment
Open

code: Rework vote extensions #717

romac opened this issue Dec 19, 2024 · 1 comment
Labels
code Code/implementation related P: high Priority: high vote-extensions Related to vote extensions
Milestone

Comments

@romac
Copy link
Member

romac commented Dec 19, 2024

The way vote extensions work right now is very cumbersome and to be frank quite confusing.

A vote extension is currently added to a precommit by looking up the corresponding full proposal assembled by the application and copying the extension found there into the precommit. This complicates the logic and mixes up the vote extension process with the building of the proposal. Moreover, and because that process is so twisty, I am not even sure that this is implemented either fully or correctly at the moment, cf. this TODO.

Instead we should add a dedicated effect to the core consensus library which would be relayed to the application, allowing to explicitly extend its vote if it chooses to.

@romac romac added the code Code/implementation related label Dec 19, 2024
@romac romac added this to the Phase 5 milestone Dec 19, 2024
@romac romac added the P: high Priority: high label Dec 19, 2024
@cason
Copy link
Contributor

cason commented Jan 6, 2025

In addition to the architectural comments, I would add that send arbitrary-size vote extensions should use a different dissemination network. Vote extensions are payloads, they should be broadcast using communication channels that are more concerned with high throughput and low duplication than strong reliability and low latency.

@romac romac added the vote-extensions Related to vote extensions label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code/implementation related P: high Priority: high vote-extensions Related to vote extensions
Projects
None yet
Development

No branches or pull requests

2 participants