Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the chain-id value from the chain #75

Open
andynog opened this issue Dec 9, 2022 · 0 comments
Open

Use the chain-id value from the chain #75

andynog opened this issue Dec 9, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@andynog
Copy link
Contributor

andynog commented Dec 9, 2022

Re-evaluate the need to have the chain-id in the config. A better approach would be to retrieve it from the chain itself like the account number and sequence. Had an issue that the chain had upgraded and the id had changed but the config had the old id.

Or at least check the local chain-id value against the real value from chain and prevent a transaction to be pushed if they differ (but then if you need to retrieve the remote chain-id what is the value of having a local config of that?).

@andynog andynog added the enhancement New feature or request label Dec 9, 2022
@andynog andynog added this to the multisig - v0.5.0 milestone Dec 9, 2022
@andynog andynog self-assigned this Dec 9, 2022
@mircea-c mircea-c removed this from the multisig - v0.5.0 milestone Jun 26, 2023
@andynog andynog removed their assignment Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants