Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend SetupCommand to create parameters.yml #7

Closed
ingowalther opened this issue Oct 11, 2016 · 16 comments
Closed

Extend SetupCommand to create parameters.yml #7

ingowalther opened this issue Oct 11, 2016 · 16 comments

Comments

@ingowalther
Copy link
Owner

Let the SetupCommand create the parameters.yml by questioning the user for the Database-Informations.

@xRahul
Copy link

xRahul commented Oct 11, 2016

Hey @ingowalther

I'll take this one!

@ingowalther
Copy link
Owner Author

@xRahul thank you!

@luchianenco
Copy link
Contributor

as I understand = the parameters.yml will be created during composer install, so do you mean to update parameters.yml db configuration?

@ingowalther
Copy link
Owner Author

At the moment you have to copy the parameters.yml.dist by hand.

It would be cool if the parameters.yml is created while executing the setup command. But there is a issue that the container requires the existence of the parameters.yml

@luchianenco
Copy link
Contributor

I think that it is possible to make it automatic by https://github.com/Incenteev/ParameterHandler
and updating composer.json file, then during composer install the parameters.yml will created and you will be prompted to enter parameters or to use the default ones

@ingowalther
Copy link
Owner Author

Oh that looks great! I also like the idea to execute the installation as composer post-install script. It looks like the best an cleanest solution to me.

@luchianenco
Copy link
Contributor

ready for PR, but don't see if you merged the previous PR

@ingowalther
Copy link
Owner Author

Your solution looks good! But maybe it is a good idea to create a seperate config for the "binary_path" and "command" elements and copy a dist file after composer install. It the most use-cases you will use the default and it is a little bit annoying to push enter for every element. What do you think?

@ingowalther
Copy link
Owner Author

Or maybe we wait till they will merge Incenteev/ParameterHandler#95

@xRahul
Copy link

xRahul commented Oct 12, 2016

This looks to be the good solution.. I'll leave it to @surgun9 then

@luchianenco
Copy link
Contributor

Well, of course we can split config, but you do it only once and you need just to press enter if you will use default value....later when parametersHandler will be updated we can update the composer.json

@ingowalther
Copy link
Owner Author

Okay. That is fine for me at the moment!

@luchianenco
Copy link
Contributor

so what is your decision?

@ingowalther
Copy link
Owner Author

ingowalther commented Oct 12, 2016

I will merge #10 later. It is okay for me at the moment.
Thank you for your work!

@luchianenco
Copy link
Contributor

ok, you are welcome

@ingowalther
Copy link
Owner Author

Done with #10!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants