Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: dynamic encoding based on the filtered data #1235

Open
3 tasks done
kumamiao opened this issue Oct 9, 2024 · 1 comment
Open
3 tasks done

[Feature Request]: dynamic encoding based on the filtered data #1235

kumamiao opened this issue Oct 9, 2024 · 1 comment
Labels

Comments

@kumamiao
Copy link

kumamiao commented Oct 9, 2024

Feature description

Similar requests have been brought up before in the last round of UI updates, and the decision was to keep teal.slice simple and only performs data slicing and not data manipulation such as dropping factor levels here. So the dynamic filtering would then need to occur on the module level. Happy to hear your thoughts on this @khatril @shajoezhu @donyunardi

User story:

is it possible to have dynamic updating for the encodings based on the active filters?

Here's an example of what I am asking:

Take the Kaplan Meier Plot... if I add ADSL.ARM as an active filter and click off "C: Combination", the Groups for the arm_ref_group do not get updated to omit "C: Combination" as an option.
image

Doing so instead results like so:

image
"Current ADSL data does not have observations from the reference and comparison treatments."

... which isn't unexpected, but I am wondering if instead we can have it dynamically remove filtered out values?

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@vedhav
Copy link
Contributor

vedhav commented Oct 17, 2024

This issue is also connected with insightsengineering/teal.goshawk#288
It boils down to whether we should use the filtered or non-filtered data for the encoding panel widget. Each widget can independently choose to use filtered or non-filtered data.
In this issue the suggestion is to make use of the filtered data for the draggable buckets widget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants