Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: new 'ggpp' release 0.5.7 #748

Closed
3 tasks done
aphalo opened this issue May 4, 2024 · 2 comments
Closed
3 tasks done

[Bug]: new 'ggpp' release 0.5.7 #748

aphalo opened this issue May 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working core

Comments

@aphalo
Copy link

aphalo commented May 4, 2024

What happened?

Not really a bug, but I am about to submit 'ggpp' 0.5.7 to CRAN. Using 'revdepcheck' locally, the check of 'teal.modules.general' does not complete (has been now running for nearly 2 hours and continues). You may like to check that the new version of 'ggpp' does not break anything. I do not expect it to break anything. It does depend on 'ggplot2' >= 3.5.0 while your package depends on 'ggplot2' >= 3.4.0.

image

This is already a retry, so other reverse dependencies had already been checked good the day before.

sessionInfo()

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@aphalo aphalo added the bug Something isn't working label May 4, 2024
@donyunardi
Copy link
Contributor

Thanks for the heads up @aphalo
We'll double check again on our end.

@averissimo averissimo self-assigned this Jul 12, 2024
@averissimo
Copy link
Contributor

Some unique scenario may have happened with that revdepcheck. I've tried replicating it as well as doing the recommended replacement method of tools::check_packages_in_dir() and no errors nor stalls happened (as revdepcheck is unmaintained).

  • revdepcheck::revdep_check(dependencies = "Suggests")
    • Took 40mins with teal.modules.general taking around 10mins
  • tools::check_packages_in_dir(".", reverse = list(repos = getOption("repos"), which = "Suggests"))

Tested with ggpp 0.5.7, 0.5.8 and 0.5.8-2

Thanks for reporting and create a new issue if the issue reappears

ps. internally we are doing weekly testing with main version of all dependencies and that is passing: see max strategy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core
Projects
None yet
Development

No branches or pull requests

3 participants