Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modules to use teal_data instead of tdata #338

Closed
10 tasks done
gogonzo opened this issue Oct 18, 2023 · 1 comment · Fixed by #344
Closed
10 tasks done

Fix modules to use teal_data instead of tdata #338

gogonzo opened this issue Oct 18, 2023 · 1 comment · Fixed by #344
Assignees
Labels

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Oct 18, 2023

part of insightsengineering/teal#937

installation instructions:

staged.dependencies::dependency_table(
  project = "insightsengineering/teal.modules.hermes@https://github.com",
  project_type = "repo@host",
  ref = "refactor",
  verbose = 1
) |>
staged.dependencies::install_deps()

Why only a single branch/PR for this?

The tdata changes are well modularised into experimentSpec.R and adtteSpec.R which process the tdata and provide functions that can be used in the modules to get the MAE data, and the modules are using this MAE data throughout and do not care about tdata or teal_data.

Review Steps:

  1. Assign yourself by writing your name next to the module in "Review list" below.
  2. Review the corresponding module
  3. Make any suggestions on the PR ;)

Review list:

@gogonzo
Copy link
Contributor Author

gogonzo commented Nov 27, 2023

Closing an issue as changes are already on the feature branch

@gogonzo gogonzo closed this as completed Nov 27, 2023
@gogonzo gogonzo self-assigned this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant