Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the refactor branch #731

Closed
8 tasks done
nikolas-burkoff opened this issue Sep 15, 2022 · 1 comment
Closed
8 tasks done

Merge the refactor branch #731

nikolas-burkoff opened this issue Sep 15, 2022 · 1 comment
Assignees
@nikolas-burkoff
Labels
core priority

Comments

@nikolas-burkoff
Copy link
Contributor

nikolas-burkoff commented Sep 15, 2022 •
edited
Loading

Closed when the following are merged.

See insightsengineering/NEST-roadmap#69 for more details and what else needs to be done as part of the refactor

Key things to check:

  1. The modules and sample apps still work:
  • the SRC shows the code needed to generate the output (play with the filter panel and encodings and make sure that changes are reflected in the code).
  • the warnings and error handling works smoothly
  • confirm we don't have a performance hit moving to qenv
  1. The docs in teal.code and teal are clear - if not then please improve them!

Be aware that there are things still be done after the merge - see roadmap issue linked above - so when testing check if issue is already there first and if you do create a new issue then please add it to the roadmap issue
@nikolas-burkoff nikolas-burkoff mentioned this issue Sep 15, 2022
Closed
@donyunardi

This comment was marked as outdated.

Sign in to view
@gogonzo gogonzo mentioned this issue Sep 16, 2022
Merged
@nikolas-burkoff nikolas-burkoff self-assigned this Sep 20, 2022
@nikolas-burkoff nikolas-burkoff mentioned this issue Sep 22, 2022
Merged
@nikolas-burkoff nikolas-burkoff removed their assignment Sep 22, 2022
@donyunardi donyunardi mentioned this issue Oct 7, 2022
Closed
21 tasks
@nikolas-burkoff nikolas-burkoff self-assigned this Oct 25, 2022
This was referenced Oct 27, 2022
Merged
Merged
Merged
Merged
Merged
Merged
gogonzo added a commit to insightsengineering/teal.code that referenced this issue Nov 4, 2022
@pawelru @gogonzo
@mhallal1 @github-actions
Teal refactor (#66)
2fc8018 
Part of insightsengineering/teal#731

Signed-off-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
Signed-off-by: Nikolas Burkoff <nikolas.burkoff@tessella.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <dawid.kaledkowski@gmail.com>
Co-authored-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
Co-authored-by: Nikolas Burkoff <nikolas.burkoff@tessella.com>
Co-authored-by: Mahmoud Hallal <mahmoud.hallal@roche.com>
Co-authored-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
gogonzo added a commit that referenced this issue Nov 4, 2022
@gogonzo @BLAZEWIM
@mhallal1 @github-actions @donyunardi
Teal refactor (#768)
4617eb7 
Part of #731

Signed-off-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
Signed-off-by: Nikolas Burkoff <nikolas.burkoff@tessella.com>
Co-authored-by: Dawid Kałędkowski <dawid.kaledkowski@gmail.com>
Co-authored-by: Blazewim <marek.blazewicz@contractors.roche.com>
Co-authored-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Co-authored-by: Dony Unardi <donyunardi@gmail.com>
gogonzo added a commit to insightsengineering/teal.modules.general that referenced this issue Nov 4, 2022
@Polkas @gogonzo
@mhallal1 @github-actions @dependabot-preview
Teal refactor (#485)
bf8a4a0 
Part of insightsengineering/teal#731

Signed-off-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
Signed-off-by: Nikolas Burkoff <nikolas.burkoff@tessella.com>
Co-authored-by: Maciej Nasinski <nasinski.maciej@gmail.com>
Co-authored-by: Dawid Kałędkowski <dawid.kaledkowski@gmail.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Co-authored-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
gogonzo added a commit to insightsengineering/teal.goshawk that referenced this issue Nov 4, 2022
@mhallal1 @Polkas
@github-actions @gogonzo @dependabot-preview
Teal refactor (#203)
6b599f8 
Part of insightsengineering/teal#731 - will
need core team input as well as Nick P's

Signed-off-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
Signed-off-by: Nikolas Burkoff <nikolas.burkoff@tessella.com>
Co-authored-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
Co-authored-by: Maciej Nasinski <nasinski.maciej@gmail.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <dawid.kaledkowski@gmail.com>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
gogonzo added a commit to insightsengineering/teal.modules.clinical that referenced this issue Nov 4, 2022
@pawelru @gogonzo
@mhallal1 @Polkas @BLAZEWIM
Teal refactor (#598)
f79d2c4 
Part of insightsengineering/teal#731

FYI @shajoezhu once this goes in SME will be able to test the refactor
hasn't broken anything

Signed-off-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
Signed-off-by: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Co-authored-by: Mahmoud Hallal <mahmoud.hallal@roche.com>
Co-authored-by: Maciej Nasinski <nasinski.maciej@gmail.com>
Co-authored-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
Co-authored-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
Co-authored-by: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <dawid.kaledkowski@gmail.com>
gogonzo added a commit to insightsengineering/teal.osprey that referenced this issue Nov 4, 2022
@gogonzo @insights-engineering-bot
@cicdguy @github-actions @mhallal1 @Polkas @dependabot-preview @BLAZEWIM
Teal refactor (#192)
141b95f 
Part of insightsengineering/teal#731

Signed-off-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
Signed-off-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Co-authored-by: Insights Engineering Bot <68416928+insights-engineering-bot@users.noreply.github.com>
Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com>
Co-authored-by: cicdguy <cicdguy@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
Co-authored-by: Maciej Nasinski <nasinski.maciej@gmail.com>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Blazewim <marek.blazewicz@contractors.roche.com>
Co-authored-by: Dawid Kałędkowski <dawid.kaledkowski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikolas-burkoff nikolas-burkoff

Labels
core priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@donyunardi @nikolas-burkoff