Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a template from this repo doesn't run actions automatically #5

Open
marissamarym opened this issue Sep 30, 2020 · 18 comments
Open
Assignees
Labels
bug If this is a bug

Comments

@marissamarym
Copy link
Contributor

The actions in the /workflow file are waiting on a change to those files, and that's not triggered when the repo is created.

Right now, you'd have to edit both the label and milestone yml files to trigger the workflows.

We want the actions to trigger automatically upon repo creation.

@marissamarym marissamarym added the bug If this is a bug label Sep 30, 2020
@marissamarym marissamarym added this to the 🥏 Frisbee milestone Sep 30, 2020
@marissamarym
Copy link
Contributor Author

Richard Robinson thanks for taking this- let me know if you have any Qs!

@rr-codes
Copy link

rr-codes commented Oct 1, 2020

Marissa M Could you give a bit more information about the issue? I’m a bit confused about the actual problem

@marissamarym
Copy link
Contributor Author

marissamarym commented Oct 1, 2020

For sure, here are the repro steps:

  1. A user sees this repo template with built in actions
  2. They create a repository from the template
  3. When they check the actions tab in GitHub, they see that no actions have run yet (and the actions are responsible for setting the labels and milestones).

This is because the actions are triggered on the event of changing a certain file, but when you create a new repo, GitHub doesn’t send file changed events for all the files. So because the events aren’t sent, the labels and milestones aren’t being initialized

@marissamarym
Copy link
Contributor Author

The task is to figure out if there is an event that is sent after a repository is created that we could additionally listen to, to trigger the actions

@rr-codes
Copy link

rr-codes commented Oct 1, 2020

ah ok, that makes more sense, thanks!!

@marissamarym
Copy link
Contributor Author

👍

@marissamarym marissamarym changed the title Creating a template from this repo needs doesn't run actions automatically Creating a template from this repo doesn't run actions automatically Oct 1, 2020
@rr-codes
Copy link

rr-codes commented Oct 1, 2020

do you think this event also triggers when a master branch is created?

image.png

@rr-codes
Copy link

rr-codes commented Oct 1, 2020

Marissa M can you give me permission to push to a branch for this repo please?

rr-codes pushed a commit that referenced this issue Oct 1, 2020
rr-codes pushed a commit that referenced this issue Oct 1, 2020
@rr-codes
Copy link

rr-codes commented Oct 1, 2020

Marissa M how do I actually test if my changes fixed the issue? Since you can’t use Use this template from a particular branch, only master

@marissamarym
Copy link
Contributor Author

hmm not an ideal solution, but you might have to create a fork with your changes, make that a template, and test making a repo out of it. pretty manual but good thing that GH doesn't charge for new repos!

@marissamarym
Copy link
Contributor Author

And yeah I think listening to create could possibly work

@rr-codes
Copy link

rr-codes commented Oct 1, 2020

this means it works right?

image.png

@rr-codes
Copy link

rr-codes commented Oct 1, 2020

and they both just completed

@marissamarym
Copy link
Contributor Author

Yeah looks like it! If you create a separate branch, does it trigger? We probably dont want it to trigger on new branches other than main/master

@rr-codes
Copy link

rr-codes commented Oct 1, 2020

lemme check

@rr-codes
Copy link

rr-codes commented Oct 1, 2020

ah yes it does trigger on a new branch creation

@rr-codes
Copy link

rr-codes commented Oct 1, 2020

ill see if theres any options

@rr-codes
Copy link

rr-codes commented Oct 1, 2020

ok ya it doesnt seem to allow you to specify the branch

@marissamarym marissamarym removed this from the 🥏 Frisbee milestone Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug If this is a bug
Projects
None yet
Development

No branches or pull requests

2 participants