Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Rename GetMetricTypes #39

Open
kindermoumoute opened this issue Oct 20, 2016 · 1 comment
Open

Rename GetMetricTypes #39

kindermoumoute opened this issue Oct 20, 2016 · 1 comment
Labels
enhancement tracked

Comments

@kindermoumoute
Copy link
Contributor

Rename GetMetricTypes was named that way because we use plugin.MetricType in the old library. Naming this method GetMetrics or GetMetricList would make more sense.

AFAIK, 2 collector plugins would be affected by this change: "mock1-grpc" (Snap repo) and "rand" (this repo).
@IRCody
Copy link
Contributor

IRCody commented Nov 2, 2016

@kindermoumoute: Not sure I agree with this. Seems like renaming that could result in confusion when migrating existing plugins to use this library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement tracked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IRCody @kindermoumoute @snapbot