Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'no such source' for comid #28

Closed
gzt5142 opened this issue Dec 16, 2024 · 3 comments · Fixed by #31
Closed

'no such source' for comid #28

gzt5142 opened this issue Dec 16, 2024 · 3 comments · Fixed by #31
Assignees
@gzt5142

Comments

@gzt5142
Copy link
Collaborator

gzt5142 commented Dec 16, 2024

Routing issue.

When testing locally, the routes are distinguished:

  • /linked-data/comid/
  • /linked-data/{sourceID}/

but when running deployed, that first route is not prioritized over second... And "comid" is not a valid sourceID.
@gzt5142
Copy link
Collaborator Author

gzt5142 commented Dec 18, 2024

This looks to be related too how the comid parameter was defined in the openapi spec.

I think we've got it sorted.

@gzt5142 gzt5142 linked a pull request Dec 18, 2024 that will close this issue
openapi fixes #31
Merged
@gzt5142 gzt5142 reopened this Dec 19, 2024
@gzt5142
Copy link
Collaborator Author

gzt5142 commented Dec 19, 2024

Didn't fix it in all areas. Re-opening.

@gzt5142
Copy link
Collaborator Author

gzt5142 commented Dec 19, 2024

/api/nldi-py/linked-data/comid/13294128/navigation/DM/flowlines?distance=9

@gzt5142 gzt5142 self-assigned this Dec 19, 2024
@gzt5142 gzt5142 mentioned this issue Dec 19, 2024
Merged
@gzt5142 gzt5142 closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzt5142 gzt5142

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

openapi fixes internetofwater/nldi-py
1 participant
@gzt5142