Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

FFT #21

Open
25 tasks
willtebbutt opened this issue May 24, 2017 · 4 comments
Open
25 tasks

FFT #21

willtebbutt opened this issue May 24, 2017 · 4 comments

Comments

@willtebbutt
Copy link
Member

willtebbutt commented May 24, 2017

Lots of FFT-related operations to support:

  • - fft
  • - ifft
  • - bfft
  • - plan_fft + associated operators
  • - plan_ifft + associated operators
  • - plan_bfft + associated operators
  • - rfft
  • - irfft
  • - brfft
  • - plan_rfft + associated operators
  • - plan_irfft + associated operators
  • - plan_rbfft + associated operators
  • - dct
  • - idct
  • - plan_dct + associated operators
  • - plan_idct + associated operators
  • - fftshift (might not be differentiable)
  • - ifftshift (might not be differentiable)
  • - filt
  • - deconv
  • - conv
  • - conv2
  • - xcorr
  • - r2r (not sure what this is yet)
  • - plan_r2r (not sure what this is yet)

Note that a large subset of the above accept / produce complex-valued inputs / outputs. It might therefore be necessary to have extended the RMAD package to handle complex-valued quantities.

@ararslan
Copy link
Collaborator

Note that these functions are no longer in Base: the FFT functionality is now in FFTW and the DSP functionality in DSP. So extending these would require including them as dependencies, which I don't think we want to do.

@iamed2
Copy link
Member

iamed2 commented Apr 12, 2019

Would it? Or would it just be sufficient to include https://github.com/JuliaMath/AbstractFFTs.jl?

@ararslan
Copy link
Collaborator

Oh, I had forgotten about AbstractFFTs. Yeah, we could use that. Doesn't cover the DSP stuff but it would suffice for FFTs.

@willtebbutt
Copy link
Member Author

I think I probably put the cart before the horse with this issue -- Nabla doesn't really have support for Complex numbers, so we would need to think carefully about this (if we want to do it). I'm half tempted to say that we should just close this issue because it's quite unlikely that we'll ever actually want to implement support for Complex numbers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants