WCAG 2.0 failure on buttons

[scotty6435]

The replacement of div controls with buttons causes Colorbox to fail WCAG 2.0 validation because they do not have a title or label. I've tested adding labels successfully, is this something you would be willing to add in? Because the controls are all image replaced this shouldn't cause any conflicts.

[jackmoore]

Sure, I would consider adding this. Could you provide me a reference to the guideline? I don't understand why a button needs a title or label if it already has text.

[scotty6435]

No problem, here's the link to the spec:
http://www.w3.org/TR/WCAG20-TECHS/H91

I have just tested again and noticed that the button text values are added only when you open a colorbox. Because the HTML for the wrapper is created on page load, the buttons don't get properly labelled until then.

[jackmoore]

Oh ok. I'm not too worried about them being empty at the beginning because I plan on replacing that soon so that it's only created on demand.

[scotty6435]

Excellent! I've got a patch in to resolve it on my end so I'm happy. Once on demand makes it into a release I'll be a happy boy :-)

[lkmorlan]

Duplicate of #765.