Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxHeight and resize #634

Open
lufton opened this issue Aug 12, 2014 · 4 comments
Open

maxHeight and resize #634

lufton opened this issue Aug 12, 2014 · 4 comments

Comments

@lufton
Copy link

lufton commented Aug 12, 2014

If I set .colorbox{maxHeight:'95%'...} then colorbox frame gets vertical scrollbar (if content is heighter than frame) but if then I do $.colorbox.resize() my colorbox frame becomes heighter than wrapper page and my maxHeight option is ignored, so the solution I see is to make changes to resize method:

if (!options.innerHeight && !options.height) {
scrolltop = $loaded.scrollTop();
$loaded.css({height: "auto"});
settings.h = $loaded.height();
if(settings.h>settings.mh) $loaded.css({height: settings.h=settings.mh}); //!!! Bugfix
}

@aik099
Copy link

aik099 commented Aug 12, 2014

Could you please do a fix in Pull Request format?

@lufton
Copy link
Author

lufton commented Aug 13, 2014

I'l try, but I'm not familiar with git pull request.
12.08.2014 19:18 пользователь "Alexander Obuhovich" <
notifications@github.com> написал:

Could you please do a fix in Pull Request format?


Reply to this email directly or view it on GitHub
#634 (comment).

@aik099
Copy link

aik099 commented Aug 13, 2014

Here are some manual for you: https://help.github.com/articles/using-pull-requests

@lufton
Copy link
Author

lufton commented Aug 13, 2014

Ok, I've created pull request #635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants