Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string format for height causes page to blow up #32

Open
jacobworrel opened this issue May 17, 2020 · 1 comment
Open

string format for height causes page to blow up #32

jacobworrel opened this issue May 17, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jacobworrel
Copy link
Owner

first mentioned here: #31

I've found that if I use a height format other than a pure number, such as "100px", it breaks so hard I have to force kill my Chrome tab. Easy enough to fix, but it might be worth noting in the documentation that heights must be provided in only that format.
@jacobworrel jacobworrel added the good first issue Good for newcomers label May 17, 2020
@jacobworrel
Copy link
Owner Author

Added a comment to the docs - it still might be a good idea to support strings like 100px although I'm not sure if this is an issue with react-windowed-select or react-select so would need to dig deeper.

@jacobworrel jacobworrel added the bug Something isn't working label May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacobworrel