Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Kafka exporter to respect max message size #6439

Open
yurishkuro opened this issue Dec 29, 2024 · 8 comments
Open

Enhance Kafka exporter to respect max message size #6439

yurishkuro opened this issue Dec 29, 2024 · 8 comments
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement storage/kafka

Comments

@yurishkuro
Copy link
Member

This is a copy of the upstream issue open-telemetry/opentelemetry-collector-contrib#36982 that we encountered, creating a ticket here to track and for better discoverability.

Problem is described here: #6437 (comment)

@yurishkuro yurishkuro added good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement labels Dec 29, 2024
@Riteek712
Copy link

@yurishkuro I would like to contribute to this issue can you please assign me this?

@yurishkuro
Copy link
Member Author

consider it assigned

@Riteek712
Copy link

Hi @yurishkuro , I am just informing you that I'm working on this issue, I came down with a cold last week, I am sorry for the delay.

@ADI-ROXX
Copy link
Contributor

ADI-ROXX commented Jan 12, 2025

@yurishkuro This issue seems to be in limbo. So I would also like to work on this.

@Riteek712 Can we contribute together on this issue?

@Riteek712
Copy link

@ADI-ROXX sure, can you mention your email for correspondence?

@ADI-ROXX
Copy link
Contributor

@yurishkuro Can you provide some commands to duplicate the problem on our own system?

@shivanshuraj1333
Copy link

hey folks, I'm working on this as it is needed for us, the splitting logic for traces is not straight forward for spans, had to do binary search over spans.

Here's a PR open-telemetry/opentelemetry-collector-contrib#37176, I have added unit tests.
Would open it up for review once I have manually tested it with a kafka cluster that the splitting is happening as expected.

@ADI-ROXX
Copy link
Contributor

Okay @shivanshuraj1333 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement storage/kafka
Projects
None yet
Development

No branches or pull requests

4 participants