Skip to content
This repository has been archived by the owner on Dec 9, 2018. It is now read-only.

Don't leak thread stack on exit #131

Open
tbu- opened this issue Apr 15, 2017 · 2 comments
Open

Don't leak thread stack on exit #131

tbu- opened this issue Apr 15, 2017 · 2 comments
Labels
bug

Comments

@tbu-
Copy link
Collaborator

tbu- commented Apr 15, 2017

Current implementation does not bother with freeing the child thread's resources.
@japaric
Copy link
Owner

japaric commented Apr 23, 2017

Isn't this equivalent to #134? You need to implement Drop for Thread to not leak the stack, right?

@japaric japaric added the bug label Apr 23, 2017
@tbu-
Copy link
Collaborator Author

tbu- commented Apr 23, 2017

No, this is orthogonal. Drop on the thread handle should detach the thread (whatever that means) and destructing thread-local data must happen on thread exit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@japaric @tbu-