Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still maintained? #61

Closed
marabesi opened this issue Feb 26, 2021 · 14 comments
Closed

Still maintained? #61

marabesi opened this issue Feb 26, 2021 · 14 comments

Comments

@marabesi
Copy link
Collaborator

Hello there,

Is this repo being maintaned? I know from npm that it has 22k monthly downloads, but on the other hand, the merge requests are open for a while.

I am interested in maintain this repo (if needed), let me know what I should do if that is the case.

@jasonsims
Copy link
Owner

Hi @marabesi , thanks for reaching out. This is no longer maintained as I believe the AWS SDK has added this functionality. If you would like to take it over I'm happy to transfer ownership to you. Just let me know!

@MollardMichael
Copy link

Hello @jasonsims
I'm really lost in the docuementation for aws sdk v3.

How can I generate a CF presigned Url using it ?

@miccl
Copy link

miccl commented Mar 2, 2021

Hi @MollardMichael,
I needed it for myself, so I share my solution. You can use the Cloudfront-Signer aws-sdk v2. Sadly it is, as far as I know, currently not included in aws-sdk/v3 (see: #1822).

Here a short example of how to use it (in typescript):

import * as Cloudfront from 'aws-sdk/clients/cloudfront';

const signer: Cloudfront.Signer = new Cloudfront.Signer(
      process.env.CLOUDFRONT_PUBLIC_KEY_ID,
      process.env.CLOUDFRONT_PRIVATE_KEY,
);

const signedUrl = signer.getSignedUrl({
      url: `https://example.com/path/to/your/url.png`
});

Hope that helps :)

@marabesi
Copy link
Collaborator Author

marabesi commented Mar 2, 2021

@miccl is this just for signedUrls? Do you know if the functionality for cookies have been migrated to aws-sdk as well?

@marabesi
Copy link
Collaborator Author

marabesi commented Mar 2, 2021

Hey @jasonsims ths for the reply, maybe you could add me as a collaborator? Changing the ownership breaks smtg on npm?

@miccl
Copy link

miccl commented Mar 2, 2021

@miccl is this just for signedUrls? Do you know if the functionality for cookies have been migrated to aws-sdk as well?

According to documentation, it is part of the aws-sdk (Cloudfront-Signer#getSignedCookie). But I only tried the signedUrl method.

@jasonsims jasonsims pinned this issue Mar 5, 2021
@jasonsims
Copy link
Owner

@marabesi I've invited you as a collaborator on this repo in case you still need it.

@marabesi
Copy link
Collaborator Author

marabesi commented Mar 8, 2021

related to #54

@hmomin
Copy link
Collaborator

hmomin commented Mar 13, 2021

Hi @jasonsims,

Could you add me as a collaborator as well? I would like to push #58 to the main branch. There is a serious vulnerability in an old lodash dependency that keeps me up at night and this library is the only one that's reliably worked for me in returning signed cookies. Thank you

@mwgamble
Copy link

mwgamble commented Jun 2, 2021

This is no longer maintained as I believe the AWS SDK has added this functionality.

The V2 SDK has this functionality, but the V3 SDK does not as of today.

@cloudworkpro-dave
Copy link

cloudworkpro-dave commented Jul 26, 2021

Hi @jasonsims,

Do you have an idea of when this functionality will be included in v3? It's concerning to me that this library is no longer maintained and also not included in v3. Do you know why it's not included in v3 so far? It's a core piece of the SDK and an important part of your services. At the very least I feel like it needs to be called out in the docs of v3 because like me, I'm sure there are a lot of other people trying to figure out what's going on. Would really appreciate the clarity on this. Thanks!

@DewaldDeJager
Copy link

@jasonsims I'm also interested in collaborating on this project while we wait for support to be added to the AWS SDK v3. This library works great!

@hmomin hmomin unpinned this issue Jan 24, 2022
@hmomin hmomin pinned this issue Jan 24, 2022
@keithalpichi
Copy link

I have an open PR for adding this functionality into the v3 library.

@jasonsims
Copy link
Owner

I'll continue to maintain this repo as long as people want to use it. It is supported in the aws-sdk but it seems like there are cases where using this library is preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants