-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Still maintained? #61
Comments
Hi @marabesi , thanks for reaching out. This is no longer maintained as I believe the AWS SDK has added this functionality. If you would like to take it over I'm happy to transfer ownership to you. Just let me know! |
Hello @jasonsims How can I generate a CF presigned Url using it ? |
Hi @MollardMichael, Here a short example of how to use it (in typescript):
Hope that helps :) |
@miccl is this just for signedUrls? Do you know if the functionality for cookies have been migrated to aws-sdk as well? |
Hey @jasonsims ths for the reply, maybe you could add me as a collaborator? Changing the ownership breaks smtg on npm? |
According to documentation, it is part of the aws-sdk (Cloudfront-Signer#getSignedCookie). But I only tried the signedUrl method. |
@marabesi I've invited you as a collaborator on this repo in case you still need it. |
related to #54 |
Hi @jasonsims, Could you add me as a collaborator as well? I would like to push #58 to the main branch. There is a serious vulnerability in an old lodash dependency that keeps me up at night and this library is the only one that's reliably worked for me in returning signed cookies. Thank you |
The V2 SDK has this functionality, but the V3 SDK does not as of today. |
Hi @jasonsims, Do you have an idea of when this functionality will be included in v3? It's concerning to me that this library is no longer maintained and also not included in v3. Do you know why it's not included in v3 so far? It's a core piece of the SDK and an important part of your services. At the very least I feel like it needs to be called out in the docs of v3 because like me, I'm sure there are a lot of other people trying to figure out what's going on. Would really appreciate the clarity on this. Thanks! |
@jasonsims I'm also interested in collaborating on this project while we wait for support to be added to the AWS SDK v3. This library works great! |
I have an open PR for adding this functionality into the v3 library. |
I'll continue to maintain this repo as long as people want to use it. It is supported in the aws-sdk but it seems like there are cases where using this library is preferred. |
Hello there,
Is this repo being maintaned? I know from npm that it has 22k monthly downloads, but on the other hand, the merge requests are open for a while.
I am interested in maintain this repo (if needed), let me know what I should do if that is the case.
The text was updated successfully, but these errors were encountered: