Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Incompatible with Django 3.2 and python-binary-memcached<=0.29 #20

Open
DrMeers opened this issue Apr 16, 2021 · 4 comments
Open

Incompatible with Django 3.2 and python-binary-memcached<=0.29 #20

DrMeers opened this issue Apr 16, 2021 · 4 comments

Comments

@DrMeers
Copy link

DrMeers commented Apr 16, 2021

  • has_key() returns True for all keys.

Presumably something to do with django/django@bb64b99 -- adding _missing_key = None makes it work correctly.

Was testing with python-binary-memcached==0.29, will try newer version and see if that supports default values in get()

@DrMeers
Copy link
Author

DrMeers commented Apr 16, 2021

0.30 changelog says "Add ability to return default value on get but breaking get’s API" so maybe that will fix it with jaysonsantos/python-binary-memcached@470b5da

@DrMeers DrMeers changed the title Incompatible with Django 3.2 Incompatible with Django 3.2? Apr 16, 2021
@DrMeers
Copy link
Author

DrMeers commented Apr 16, 2021

Confirmed it works with python-binary-memcached>=0.30 -- not sure if something can be added to the dependency info to ensure people don't get bitten by the django>=3.2 + python-binary-memcached<=0.29 combo?

@DrMeers DrMeers changed the title Incompatible with Django 3.2? Incompatible with Django 3.2 and python-binary-memcached<=0.29 Apr 16, 2021
@jaysonsantos
Copy link
Owner

Hey there @DrMeers that is a hard one to tackle as people install this package and freeze the whole venv and do not bump the required library when needed.
I'd suggest using something like poetry that would know how to deal properly with this locking.
So, if you get a the current version of django-bmemcached and python-binary-memcached, does it work?

@DrMeers
Copy link
Author

DrMeers commented May 5, 2021

So, if you get a the current version of django-bmemcached and python-binary-memcached, does it work?

Yep, confirmed above it works fine for python-binary-memcached>=0.30

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants