Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Deprecated Methods in CodeDefinition Class #73

Open
DaSourcerer opened this issue Jan 9, 2017 · 0 comments
Open

Remove Deprecated Methods in CodeDefinition Class #73

DaSourcerer opened this issue Jan 9, 2017 · 0 comments

Comments

@DaSourcerer
Copy link
Contributor

The methods incrementCounter(), decrementCounter(), resetCounter(), and getCounter() have been marked as deprecated for quite some time now and as far as I can tell, they are no longer touched by any code paths and are skewing code coverage statistics. I'd like to see them either removed or added to the code coverage blacklist. Thoughts?

Also, there's still setUseOption() and setParseContent(): These two do alter the behaviour of a CodeDefinition but are likewise marked as deprecated. What about them?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DaSourcerer