Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings in the tests #91

Open
zmoon opened this issue Mar 29, 2022 · 0 comments
Open

Deprecation warnings in the tests #91

zmoon opened this issue Mar 29, 2022 · 0 comments

Comments

@zmoon
Copy link
Contributor

zmoon commented Mar 29, 2022

I noticed some deprecation warnings when running the tests that could be addressed, related to

  • setting the background color of a GeoAxes
  • xarray argmin behavior.
xmovie/test/test_core.py: 144 warnings
  /mnt/c/Users/zmoon/git/xmovie/xmovie/presets.py:168: DeprecationWarning: The background_patch property is deprecated. Use GeoAxes.patch instead.
    ax.background_patch.set_facecolor(bgcolor)

xmovie/test/test_core.py: 48 warnings
  /home/zmoon/miniconda3/envs/xmovie-test/lib/python3.10/site-packages/xarray/core/dataarray.py:4407: DeprecationWarning: Behaviour of argmin/argmax with neither dim nor axis argument will change to return a dict of indices of each dimension. To get a single, flat index, please use np.argmin(da.data) or np.argmax(da.data) instead of da.argmin() or da.argmax().
    result = self.variable.argmin(dim, axis, keep_attrs, skipna)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant