You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As is, alphabet_aliases = "AaBb" would treat a and B as equivalent. My understanding of the documentation is that alphabet_aliases = "AaBb" should imply the two equivalence pairs A/a and B/b but not a/B.
Additionally, it might be nice to explicitly specify in the documentation that you need specify only one ordering for each equivalence pair (i.e., alphabet_aliases = "AB" is equivalent to alphabet_aliases = "ABBA").
Happy to submit a PR if that would help.
The text was updated successfully, but these errors were encountered:
Unless I'm mistaken, I believe
i+=1
should bei+=2
in two places:parasail/src/traceback.c
Lines 43 to 50 in 600fb26
parasail/src/cigar_template.c
Lines 172 to 179 in 600fb26
As is,
alphabet_aliases = "AaBb"
would treata
andB
as equivalent. My understanding of the documentation is thatalphabet_aliases = "AaBb"
should imply the two equivalence pairsA
/a
andB
/b
but nota
/B
.Additionally, it might be nice to explicitly specify in the documentation that you need specify only one ordering for each equivalence pair (i.e.,
alphabet_aliases = "AB"
is equivalent toalphabet_aliases = "ABBA"
).Happy to submit a PR if that would help.
The text was updated successfully, but these errors were encountered: