Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in template if jxSecrets.enabled=true and jxSecrets.cluster.enabled=false #63

Open
guillermomolina opened this issue Oct 12, 2023 · 0 comments · May be fixed by #64
Open

Error in template if jxSecrets.enabled=true and jxSecrets.cluster.enabled=false #63

guillermomolina opened this issue Oct 12, 2023 · 0 comments · May be fixed by #64

Comments

@guillermomolina
Copy link

Given:

jxSecrets:
  enabled: true
  cluster:
    enabled: true 

Template charts/jx-kh-check/templates/jx-secrets-check.yaml renders incorrectly:

---
apiVersion: comcast.github.io/v1
kind: KuberhealthyCheck
metadata:
  name: jx-secrets
  annotations:
    docs.jenkins-x.io: https://jenkins-x.io/v3/admin/troubleshooting/secrets/
spec:
  runInterval: <no value>
  timeout: <no value>
  podSpec:
    securityContext:
      runAsUser: 999
      fsGroup: 999
    containers:
      - env:
			  image: <no value>:<no value>
        imagePullPolicy: IfNotPresent
        name: main
        resources:
          requests:
            cpu: 10m
            memory: 50Mi
        securityContext:
          allowPrivilegeEscalation: false
          readOnlyRootFilesystem: true
    serviceAccountName: jx-secrets-sa

The "- env:" line is missing the empty array, it should be: "- env: []" or be removed

guillermomolina added a commit to guillermomolina/jenkins-x-plugins_jx-kh-check that referenced this issue Oct 12, 2023
@guillermomolina guillermomolina linked a pull request Oct 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant