Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

Git tokens need some good masking/trimming in places #549

Open
a-roberts opened this issue Oct 27, 2020 · 2 comments
Open

Git tokens need some good masking/trimming in places #549

a-roberts opened this issue Oct 27, 2020 · 2 comments

Comments

@a-roberts
Copy link

a-roberts commented Oct 27, 2020

Hey folks! So this is doing a quickstart - we went with the Go one FWIW.

Version is 3.0658.

Three things spotted...

  1. When prompted for a token to use, mask the input please 😄 I know it is masked when we do a command or two under the covers
  2. Trim the input (we had whitespace, oops, resulted in %20 of course which isn't gonna work)
  3. Mask the token in the error output too please

(p.s, I think I implemented this for jx 2...waaaay back in the day...update - ah, no, it was for rhd-gitops-example/services#26 - so some code there may be useful)

@jstrachan poke 😸

@jenkins-x-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

@jenkins-x-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle rotten

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants