diff --git a/pkg/plugins/approve/approve_test.go b/pkg/plugins/approve/approve_test.go index 2c7ab75a7..88de22a7c 100644 --- a/pkg/plugins/approve/approve_test.go +++ b/pkg/plugins/approve/approve_test.go @@ -253,8 +253,8 @@ Approvers can cancel approval by writing ` + "`/approve cancel`" + ` in a commen expectComment: true, expectedComment: `[APPROVALNOTIFIER] This PR is **NOT APPROVED** -This pull-request has been approved by: -The changes made require 1 more approval(s). +This pull-request has been approved by: +The changes made require 1 more approval(s). To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **cjwagner** You can assign the PR to them by writing ` + "`/assign @cjwagner`" + ` in a comment when ready. @@ -685,8 +685,8 @@ Approvers can cancel approval by writing ` + "`/approve cancel`" + ` in a commen comments: []*scm.Comment{ newTestComment("k8s-ci-robot", `[APPROVALNOTIFIER] This PR is **NOT APPROVED** -This pull-request has been approved by: -The changes made require 1 more approval(s). +This pull-request has been approved by: +The changes made require 1 more approval(s). To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **alice** You can assign the PR to them by writing `+"`/assign @alice`"+` in a comment when ready. @@ -764,8 +764,8 @@ Approvers can cancel approval by writing ` + "`/approve cancel`" + ` in a commen expectComment: true, expectedComment: `[APPROVALNOTIFIER] This PR is **NOT APPROVED** -This pull-request has been approved by: -The changes made require 1 more approval(s). +This pull-request has been approved by: +The changes made require 1 more approval(s). To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **cjwagner** You can assign the PR to them by writing ` + "`/assign @cjwagner`" + ` in a comment when ready. @@ -835,8 +835,8 @@ Approvers can cancel approval by writing ` + "`/approve cancel`" + ` in a commen expectComment: true, expectedComment: `[APPROVALNOTIFIER] This PR is **NOT APPROVED** -This pull-request has been approved by: -The changes made require 1 more approval(s). +This pull-request has been approved by: +The changes made require 1 more approval(s). To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **cjwagner** You can assign the PR to them by writing ` + "`/assign @cjwagner`" + ` in a comment when ready. @@ -874,8 +874,8 @@ Approvers can cancel approval by writing ` + "`/approve cancel`" + ` in a commen expectComment: true, expectedComment: `[APPROVALNOTIFIER] This PR is **NOT APPROVED** -This pull-request has been approved by: -The changes made require 1 more approval(s). +This pull-request has been approved by: +The changes made require 1 more approval(s). To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **cjwagner** You can assign the PR to them by writing ` + "`/assign @cjwagner`" + ` in a comment when ready. @@ -951,8 +951,8 @@ Approvers can cancel approval by writing ` + "`/approve cancel`" + ` in a commen expectComment: true, expectedComment: `[APPROVALNOTIFIER] This PR is **NOT APPROVED** -This pull-request has been approved by: -The changes made require 1 more approval(s). +This pull-request has been approved by: +The changes made require 1 more approval(s). To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **cjwagner** You can assign the PR to them by writing ` + "`/assign @cjwagner`" + ` in a comment when ready. @@ -987,8 +987,8 @@ Approvers can cancel approval by writing ` + "`/approve cancel`" + ` in a commen expectComment: true, expectedComment: `[APPROVALNOTIFIER] This PR is **NOT APPROVED** -This pull-request has been approved by: -The changes made require 1 more approval(s). +This pull-request has been approved by: +The changes made require 1 more approval(s). To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **cjwagner** You can assign the PR to them by writing ` + "`/assign @cjwagner`" + ` in a comment when ready. @@ -1162,8 +1162,8 @@ Approvers can cancel approval by writing ` + "`/approve cancel`" + ` in a commen expectedComment: `[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: -The changes made require 2 more approval(s). -To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **derek** +The changes made require 2 more approval(s). +To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **derek** You can assign the PR to them by writing ` + "`/assign @derek`" + ` in a comment when ready. The full list of commands accepted by this bot can be found [here](https://jenkins-x.io/v3/develop/reference/chatops/?repo=org%2Frepo). @@ -1198,8 +1198,8 @@ Approvers can cancel approval by writing ` + "`/approve cancel`" + ` in a commen expectedComment: `[APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *[derek](<> "Approved")* -The changes made require 1 more approval(s). -To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **derek** +The changes made require 1 more approval(s). +To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **derek** You can assign the PR to them by writing ` + "`/assign @derek`" + ` in a comment when ready. The full list of commands accepted by this bot can be found [here](https://jenkins-x.io/v3/develop/reference/chatops/?repo=org%2Frepo). @@ -1270,8 +1270,8 @@ Approvers can cancel approval by writing ` + "`/approve cancel` " + `in a commen expectComment: true, expectedComment: `[APPROVALNOTIFIER] This PR is **NOT APPROVED** -This pull-request has been approved by: *[alice](<> "Approved")*, *[derek](<> "Approved")* -To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **derek** +This pull-request has been approved by: *[alice](<> "Approved")*, *[derek](<> "Approved")* +To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **derek** You can assign the PR to them by writing ` + "`/assign @derek`" + ` in a comment when ready. The full list of commands accepted by this bot can be found [here](https://jenkins-x.io/v3/develop/reference/chatops/?repo=org%2Frepo).