Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save files too easy to change #462

Closed
xbfj opened this issue Oct 13, 2023 · 3 comments
Closed

save files too easy to change #462

xbfj opened this issue Oct 13, 2023 · 3 comments

Comments

@xbfj
Copy link

xbfj commented Oct 13, 2023

No description provided.

@jeremyckahn
Copy link
Owner

IMO this is a feature and not a bug. Why do you believe that the save files should be harder to change, @sjvdvd?

@xbfj
Copy link
Author

xbfj commented Oct 16, 2023

It's an online game @jeremyckahn

@xbfj xbfj closed this as completed Oct 16, 2023
@xbfj xbfj reopened this Oct 16, 2023
@jeremyckahn
Copy link
Owner

It's an online game @jeremyckahn

Yes, but online functionality was designed to be cheat-tolerant. This is achieved by limiting the effect that one player can have on another through market impact. One could modify a cow via a save file and trade it away, and an argument could be made that doing so would affect the "purity" of another player's online experience. However, this could also be achieved by modifying the game state via something like React dev tools. This can't be reasonably mitigated without a complete re-architecture of the online system, and that's not something I foresee happening.

Given that it would be relatively easy for people to cheat even with mitigations via save file obfuscation in place, I'd prefer to keep the save file as a plain JSON file. This will keep the file accessible to curious players who chose to play the game as designed and want to learn how it works.

I'm closing this issue as it's not something I'd like to include in Farmhand, but I am open to further discussion in this thread!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants