Doesn't respect LC_MESSAGES

[p-baum]

I'm getting a German language interface because of my (mostly) German settings. My LC_MESSAGES is however set to en_GB.UTF-8 which 95% of software respects. Sadly it appears lazydocker does not.

For now I will workaround with

LC_ALL=$LC_MESSAGES lazydocker

[dawidd6]

We are using github.com/cloudfoundry/jibber_jabber package for detecting what locale a user is using. If I see correctly in their source, they do not check LC_MESSAGES, in fact I'm surprised that other software is respecting this environment variable higher that LC_ALL, but maybe I just don't know something.

A quick workaround for that would be to check for LC_MESSAGES after this line:

lazydocker/pkg/i18n/i18n.go

Line 21 in d9a9477

userLang := detectLanguage(jibber_jabber.DetectLanguage)

, but I don't really think it is the ideal solution.

[mjarkk]

@dawidd6 I don't think it's a good idea we do this.
This is really just a problem of jibber_jabber and we or @p-baum should report the problem there.

It's much cleaner if they fix the problem and we just update our libraries,
No hacking required to fix the problem.

[dawidd6]

@mjarkk judging by activity in their repository, it might not be fixed anytime soon.

[mjarkk]

I'll open an issue and wait for a few days.
If no-one will reply i think it's best we fork it and make the changes our-self.

[mjarkk]

Created the issue: cloudfoundry-attic/jibber_jabber#5