Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve scikit-learn compatibility #32

Open
CarloLepelaars opened this issue Nov 23, 2022 · 0 comments
Open

Improve scikit-learn compatibility #32

CarloLepelaars opened this issue Nov 23, 2022 · 0 comments

Comments

@CarloLepelaars
Copy link

Thank you for building and open-sourcing this!

Unfortunately there are still some compatbility issues in CleanTransformer, especially when using it within Pipeline and FeatureUnion objects.

  1. y argument missing in fit.
  2. Missing partial_fit method.
  3. Missing get_feature_names_out method.

I implemented these in #31. Would be happy to discuss any changes or additional functionality + tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CarloLepelaars