Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight issue with 10.4-rc1 #3428

Closed
cymplecy opened this issue Jan 9, 2025 · 15 comments
Closed

Slight issue with 10.4-rc1 #3428

cymplecy opened this issue Jan 9, 2025 · 15 comments

Comments

@cymplecy
Copy link
Contributor

cymplecy commented Jan 9, 2025

FYI I just decided to test out my Mayflower project on it and I'm getting an error that I don't get if I run it in 10.3.6

I'm investigating to work out what's going on and I'll update when I work out what's happening

@jmoenig
Copy link
Owner

jmoenig commented Jan 9, 2025

Thanks, what's the error?

@cymplecy
Copy link
Contributor Author

cymplecy commented Jan 9, 2025

The error is
image

I'm just having trouble tracking which custom block it's from as the project is so big :)
(and messy :) )

@jmoenig
Copy link
Owner

jmoenig commented Jan 9, 2025

Ah, I was wondering if we'd see this error, so I'm glad it ocurred!
Let me look into it...

@jmoenig
Copy link
Owner

jmoenig commented Jan 9, 2025

can you perhaps share a screenshot of the entire error message? Or let me know the false case of the nested reporter-if? Thanks!

@cymplecy
Copy link
Contributor Author

cymplecy commented Jan 9, 2025

image
Ignore prev line here - I'm tired :)

@jmoenig
Copy link
Owner

jmoenig commented Jan 9, 2025

No need, this is what I wanted, thank you!

@cymplecy
Copy link
Contributor Author

cymplecy commented Jan 9, 2025

I think I've found the definition of the custom reporter
Mayflower_MAS400_V7a_Snap10_dev script pic

@jmoenig
Copy link
Owner

jmoenig commented Jan 9, 2025

thanks, but the error is actually happening in the numbers from ... to ... primitive. It's an easy and straightforward fix. I'm currently investigating if it might occur in any others as well. These are exactly the kinds of issues I love to hear about before releasing a new version!

@cymplecy
Copy link
Contributor Author

cymplecy commented Jan 9, 2025

Phew - I was getting nowhere trying to track it down :)
This is why I tried the rc out on the Mayflower project as it's got so much code in it :)

@jmoenig
Copy link
Owner

jmoenig commented Jan 9, 2025

Now that I know what to look for I found three more primitives that can run into the same issues, fixing all of them right now...

@cymplecy
Copy link
Contributor Author

cymplecy commented Jan 9, 2025

Irrelvanet to your bug squashing but I finally tracked down where the error was occuring - I can goto bed happy now :)
image

@cymplecy
Copy link
Contributor Author

cymplecy commented Jan 9, 2025

...because the substring of blocks use the other substring block I mentioned earlier
image
sorry for wrong pic 1st time

@jmoenig
Copy link
Owner

jmoenig commented Jan 9, 2025

well, before you go to bed, can you try running your project again in rc2 - which I've just installed in dev -? You may need to hard reload the page in order to flush your browser cache for this one, and then see if the error still happens? Thanks! If it's too late this has time for tomorrow, no worries :)

@cymplecy
Copy link
Contributor Author

cymplecy commented Jan 9, 2025

No error :)

@jmoenig
Copy link
Owner

jmoenig commented Jan 9, 2025

Yay, thank you!!
Now I can also go to bed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants