Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ElastAlert2 'summary_table_type' option #636

Open
sinister3vil opened this issue Apr 4, 2024 · 6 comments
Open

Support for ElastAlert2 'summary_table_type' option #636

sinister3vil opened this issue Apr 4, 2024 · 6 comments
Labels
enhancement New feature or request please contribute

Comments

@sinister3vil
Copy link

🎉 Goal

Support summary_table_type field with ascii, html and markdown options in UI.

💪 Motivation

There's currently no support for this and aggregated e-mail alerts are coming in as ascii, but not monospace, and appear quite ugly.

A different approach would be supporting direct editing of the rule YAML and any throw a message in the UI if there are unsupported options, something like "Rule includes summary_table_type option which is not supported in Praeco. Please use the YAML editor to change this option".

@sinister3vil sinister3vil added the enhancement New feature or request label Apr 4, 2024
@nsano-rururu
Copy link
Collaborator

Is it necessary to be able to set summary_table_fields on the screen?

image

@sinister3vil
Copy link
Author

Hello @nsano-rururu,

Do you mean having it as a UI option vs setting it in a config as a global setting?

@nsano-rururu
Copy link
Collaborator

UI

@sinister3vil
Copy link
Author

Well, I believe it should be configurable per rule, cause some times you may need an HTML format, others markdown and others you'd be fine with just ascii.
Do you find there's no value in having it in the UI? If not, how would it be set?

@nsano-rururu
Copy link
Collaborator

summary table
image

The following are the setting items
Only summary_table_type is required

summary_table_type
  ascii or markdown is option button

summary_prefix
 text

summary_suffix
 text

summary_table_max_rows
 number

summary_table_fields
UI like below
image

@nsano-rururu
Copy link
Collaborator

If you want to use the same settings for all rules,
Write it in the following file of rules

BaseRule.config

@nsano-rururu nsano-rururu changed the title Support for ElastAlert 'summary_table_type' option Support for ElastAlert2 'summary_table_type' option Apr 8, 2024
Repository owner locked and limited conversation to collaborators Apr 13, 2024
Repository owner deleted a comment from sinister3vil Apr 13, 2024
Repository owner unlocked this conversation Jan 1, 2025
@nsano-rururu nsano-rururu reopened this Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request please contribute
Projects
None yet
Development

No branches or pull requests

2 participants