The second object was changed when the first is "{}"

[cczw2010]

The Code:

import mixinDeep from "mixin-deep"
const a = {a:{a:1,b:0}};
const b = {a:{b:2},b:1};
const c = {a:{a:2},c:2};
const d = mixinDeep({},a,b,c);
console.log("a",a)
console.log("b",b)
console.log("c",c)
console.log("d",d)

The console output：

a { a: { a: 2, b: 2 } }
b { a: { b: 2 }, b: 1 }
c { a: { a: 2 }, c: 2 }
d { a: { a: 2, b: 2 }, b: 1, c: 2 }

why "a" is changed,

[maiermic]

Because objects are not cloned, when they are assigned. See the added log at the end:

import mixinDeep from "mixin-deep"
const a = {a:{a:1,b:0}};
const b = {a:{b:2},b:1};
const c = {a:{a:2},c:2};
const d = mixinDeep({},a,b,c);
console.log("a",a)
console.log("b",b)
console.log("c",c)
console.log("d",d)
console.log("d.a === a.a", d.a === a.a)

I suppose to change

mixin-deep/index.js

Line 29 in 8f464c8

target[key] = val;

to

target[key] = mixinDeep({}, val);

in case isObject(val).

Note: This does not clone arrays.

[cczw2010]

Thanks for the reply

[cloudrac3r]

I hit this too and thought it was a bug, but this behaviour is actually specified in the tests. I found this unintuitive and unpredictable, so I created PR 15 to make it work the way I expected.

If you need to use my version before Jon merges my pull request, you can install it using the command npm install cloudrac3r/mixin-deep#v3.0.0