Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

All icon fonts missing #194

Closed
brianteeman opened this issue Feb 5, 2020 · 10 comments
Closed

All icon fonts missing #194

brianteeman opened this issue Feb 5, 2020 · 10 comments

Comments

@brianteeman
Copy link
Contributor

image

Steps to reproduce the issue

Install the package from developer.joomla.org
image

All the icon fonts are missing due to this error

src: url("../../../../build/media_source/system/fonts/joomla-fonts.woff2") format("woff2"),
url("../../../../build/media_source/system/fonts/joomla-fonts.woff") format("woff");

@kawshar
Copy link
Contributor

kawshar commented Feb 5, 2020

Did you run npm ci?

@brianteeman
Copy link
Contributor Author

i am referring to the prebuilt zip

@kawshar
Copy link
Contributor

kawshar commented Feb 5, 2020

I just installed and could not find any issue
image

Can someone please cross-check?

@kawshar
Copy link
Contributor

kawshar commented Feb 5, 2020

@brianteeman you downloaded from this link, right? https://github.com/joomla-projects/j4adminui/files/4158949/Joomla_4.0.0-unofficial-khonsu-dev-Development-Full_Package.zip

@brianteeman
Copy link
Contributor Author

This is the link that @marcodings gave and that I used
https://developer.joomla.org/backend-template/

The same can be seen using this
joomla/joomla-cms#27758 (comment)

You will almost certainly see on your local install that you have a build/media-source folder and thats why you have the font.

@kawshar
Copy link
Contributor

kawshar commented Feb 5, 2020

I think the build was not correct.

@brianteeman
Copy link
Contributor Author

That is why I wrote #190 (comment)

@wilsonge
Copy link
Contributor

wilsonge commented Feb 6, 2020

The build on jenkins uses the standard build script https://github.com/joomla-projects/j4adminui/blob/master/build/build.php should be reproducible - there's really nothing special happening in jenkins

It runs the command php build/build.php --remote=origin/master --exclude-gzip --exclude-bzip2 to generate the zips

@exmmth
Copy link

exmmth commented Feb 6, 2020

The build on jenkins uses the standard build script https://github.com/joomla-projects/j4adminui/blob/master/build/build.php should be reproducible - there's really nothing special happening in jenkins

Glad to see you! Thank you for you answer. We need do PR fix some files as I saw - #190

@kawshar I can try to do this PR I need you help to don't brake you "team build way".

@wilsonge in README different way to use this repo, this is promblem to need fix?

@wilsonge
Copy link
Contributor

wilsonge commented Feb 8, 2020

No - how we build the stable packages removes the developer dependencies required for local development. I can't see anything wrong with the readme.

How the files get fixed is one for the team here to work on :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants