Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor 1.2 needs node 10.40 or greater #35

Open
kingOtto opened this issue Sep 22, 2015 · 13 comments
Open

Meteor 1.2 needs node 10.40 or greater #35

kingOtto opened this issue Sep 22, 2015 · 13 comments

Comments

@kingOtto
Copy link

A lot of Meteor people use this build pack; the recent Meteor update prompts an error on Heroku that 10.40 or greater is needed. This specifies 10.36.

@hazio
Copy link

hazio commented Sep 22, 2015

Use the engines section of your package.json to specify the version of Node.js to use on Heroku:

{
  "name": "myapp",
  "description": "a really cool app",
  "version": "0.0.1",
  "engines": {
    "node": "0.10.40"
  }
}

@nerijunior
Copy link

@hazio where I set this package.json? The #34 is the fix!

@hazio
Copy link

hazio commented Sep 23, 2015

@nerijunior at root directory of your meteor app.

@nerijunior
Copy link

@hazio I've tried but no effect. :(

@leonardykris
Copy link
Contributor

@nerijunior I'm unsure whether you still need it, but you can fork the repository, then navigate to bin/compile_node and just change the specified node_engine in line 37 to "0.10.40"

@nerijunior
Copy link

@leonardykris Tks! I made this.

@tomodutch
Copy link

For the time being you can use my fork.
heroku create --buildpack https://github.com/tfarla/heroku-buildpack-meteor.git
I have created a PR #37 but it has not been merged yet.

@nerijunior
Copy link

@TFarla Tks but I made my own fork too! :)

@nanimokamo
Copy link

I'm still getting this Node 10.40 error... has this been fixed yet?

@yborunov
Copy link

Same problem, apparently have to make a fork.
PR #37 need to be merged.

@chrisbolin
Copy link

Has anyone had luck with engines, or are the PRs like #37 the best options?

@maxko87
Copy link

maxko87 commented Oct 23, 2015

If you are going with https://github.com/maxko87/heroku-buildpack-meteor.git buildpack, make sure to use this command to set it:

heroku buildpacks:set https://github.com/maxko87/heroku-buildpack-meteor.git --app yourapp

and then push to your Heroku app.

you can't just set the buildpack on the Heroku dashboard -- it won't work.

@polkhovsky
Copy link

@maxko87 Thank you for this! I can't believe it's taking so long to fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants