Regarding "fix overlapping slices w/ no SpacingBetweenSlices tag"

[AivenJC]

Regarding "fix overlapping slices w/ no SpacingBetweenSlices tag"

The commit on Mar 4, 2024 to ct.py by jrkerns seems to be incomplete at least w.r.t. this function:

def passed_thickness(self) -> bool:
    """Whether the slice thickness was within tolerance from nominal."""
    return (
        self.slice_thickness - self.thickness_tolerance
        < self.meas_slice_thickness
        < self.slice_thickness + self.thickness_tolerance
    )

"self.slice_thickness" is still the dicom property "SliceThickness" where "self.meas_slice_thickness" inherently uses "self.slice_spacing" as newly defined during the measurement. I.e. it seems that two different values are being compared and the test always fails incorrectly for datasets with overlapping slices which lack the Spacing DICOM tag.

This way the reference value "self.slice_spacing" should be properly compared to the corresponding measured value "self.meas_slice_thickness":

def passed_thickness(self) -> bool:
    """Whether the slice thickness was within tolerance from nominal."""
    return (
        self.slice_spacing - self.thickness_tolerance
        < self.meas_slice_thickness
        < self.slice_spacing + self.thickness_tolerance
    )

[jrkerns]

I'm not following the statement: "where "self.meas_slice_thickness" inherently uses "self.slice_spacing" as newly defined during the measurement." Can you share a file set that this occurs with so I can potentially add to the test suite? Thanks! https://forms.gle/As9pnsmvKBvDcRUx6