Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CatPhan504 low contrast module visibility issues #539

Open
Phillip-Duncan opened this issue Jan 16, 2025 · 0 comments
Open

CatPhan504 low contrast module visibility issues #539

Phillip-Duncan opened this issue Jan 16, 2025 · 0 comments

Comments

@Phillip-Duncan
Copy link

I discovered an issue using the CatPhan504 module for our Versa HD linac (not HU calibrated)

The CTP515 ROI values end up being negative, which causes the visibility to be negative, tested by printing the list of:

cp = CatPhan504(cp_folder)
contrast_rois = [c.contrast for c in cp.ctp515.rois.values()]

I imagine this is due to scaling/offsets not being applied and pixel values being negative, which just means returning the absolute value for the function;

return (l_max - l_min) / (l_max + l_min)
so that for cases where these offsets are not calibrated on the machine ensures that the Michelson contrast is still bound between [0, 1] for pixel values < 0.

I've also included the dataset used below for reproducibility;

dataset.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant