Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should 2013 filings be supported? #19

Open
mjalkio opened this issue Jan 4, 2019 · 4 comments
Open

Should 2013 filings be supported? #19

mjalkio opened this issue Jan 4, 2019 · 4 comments

Comments

@mjalkio
Copy link
Contributor

mjalkio commented Jan 4, 2019

The 990-xml-reader README suggests that everything from 2013 onward should be available in the standardized format:

Allowed output formats are 'csv', 'txt', and 'json'. [See the results as .csv, .txt., or .json files]. CSV and TXT are "flat" formats for human readibility, whereas the json is nested like the original tax forms (although only available for schema years 2013 and forwards).

However, when trying to load_filings 2013 I get an error RuntimeError: Illegal year 2013. Please enter a year between 2014 and 2018.

Is this intentional?

@jsfenfen
Copy link
Owner

jsfenfen commented Jan 4, 2019 via email

@bcipolli
Copy link

bcipolli commented Jan 6, 2020

Would be nice to avoid referring to year in this case. Docs and messages could refer to tax year and filing year?

@bcipolli
Copy link

This is also strange because we're able to load yearly submissions for 2013. Should we block that?

@jsfenfen
Copy link
Owner

jsfenfen commented Jun 2, 2020

Hey @bcipolli it's probably a good idea to separate out tax year, schema year and filing year (there are really three different ones), this might be better addressed in the docs first? Do you have an example that's loading that you think shouldn't? The key year is schema year that's the one that should determine whether a filing is parseable. Do you have an example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants