Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React App template #3

Open
ok2ju opened this issue Sep 19, 2018 · 4 comments
Open

React App template #3

ok2ju opened this issue Sep 19, 2018 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ok2ju
Copy link
Member

ok2ju commented Sep 19, 2018

Add react app template (like https://github.com/ok2ju/modern-react-boilerplate)

@ok2ju ok2ju added enhancement New feature or request help wanted Extra attention is needed labels Sep 19, 2018
@alehatsman
Copy link
Collaborator

Yes for sure. Just let's define what is the purpose of the template and what should be included.
Last days I was working on nextjs app. I created that template https://github.com/jszombies/create-zombie-lib/tree/master/templates/react-nextjs-app

@ok2ju
Copy link
Member Author

ok2ju commented Sep 19, 2018

It's boilerplate just for regular react application.
I think what it should have the following:

  • standard for linting (lets try it out);
  • webpack for bundling;
  • jest + enzyme for tests;
  • css modules (because its most common and simple approach now);
  • redux;
  • redux-saga;
  • react-router (im not sure about version, I only used v3).

@shamin
Copy link

shamin commented Oct 1, 2018

@ok2ju @atsman I have a simple react starter boilerplate with eslint for linting and sass support available at https://github.com/shaminmeerankutty/react-starter. I can also add jest, enzyme , redux, react-router (v4) to starter. Is it ok?

@ok2ju
Copy link
Member Author

ok2ju commented Oct 1, 2018

@shaminmeerankutty it looks pretty good and simple, I like it, but we came to decision that we need tools like I described above except of css modules (we should replace it with styled-components).

standard instead of eslint
styled-components instead of css/sass

If you agree with this requirements we will be happy to add your starter into our CLI. We appreciate any contribution 😃

@atsman what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants