Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] add ui kitten eva-icons support #4

Open
kockok opened this issue Jul 18, 2020 · 1 comment
Open

[Feature request] add ui kitten eva-icons support #4

kockok opened this issue Jul 18, 2020 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@kockok
Copy link

kockok commented Jul 18, 2020

Hi, I'm using the ui-kitten icons.

const evaIconRenderer = ({icon}: IIconRenderer) => <Icon name={icon} />;

const CustomTabBar: React.FC<BottomTabBarProps> = ({
  state,
  descriptors,
  navigation,
}) => {
  return (
    <BubbleTabBar
      state={state}
      descriptors={descriptors}
      navigation={navigation}
      tabs={tabs}
      iconRenderer={evaIconRenderer}
    />
  );
};

Even with the iconRenderer, I cannot get the icons show up.

Possibly this is due to the fact that eva icon is rendering icons with JSX elements.

The active highlight becomes eerily big.
Screenshot 2020-07-19 at 12 06 10 AM

@junhoyeo junhoyeo added bug Something isn't working enhancement New feature or request labels Jul 21, 2020
@junhoyeo
Copy link
Owner

@kockok, Thanks for the issue & sorry for the late reply. Hadn't check my inbox,, 😰
I promise to investigate it tommorrow ! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants