-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Better readability for time and FPS status #1225
Comments
Are you talking about the GUI or the CLI? |
Yes, I was talking about the GUI. Good to know that it doesn't update the counters in real time, but 10 times per second almost looks like real time to me. At least in terms of readability. The "jumpy" and "glitchy" behavior (for leg of a better word) doesn't make it easy to read the counters. Bildschirmaufnahme.2024-11-10.001834.mp4See how the FPS jumps back and forth and the Time Remaining doesn't give me a clear value but changes by multiple seconds all the time? My personal preference would be one rounded digit after the decimal point for FPS and one update per second for all counters. |
I don't want to add too many settings as it may overwhelm the users. I think it's fair to reduce the update speed to something more reasonable. I'd say something like twice per second would work fine. I'll also apply the adjustment for the rounding so it always shows two or three digits after the decimal point. The FPS math will be enhanced later. Right now it's just |
So for now I've set it show 4 digits after the decimal point. Slower devices like Intel iGPU may process at a rate less than 0.01 FPS sometimes, so I want to be able to show speed slower than that. I tried different progress refreshing speeds, and slower than the current (10 FPS) makes the progress bar look not as smooth, so I think I'll keep it at that for now. Will be shipped in the next release. |
Currently (Version 6.1.1) the FPS counter, "Time Elapsed" and "Time Remaining" update in real time. This makes it really hard to read what is getting displayed, especially when your remaining time is large enough for a small fluctuation in FPS to let the remaining time jump up and down 10 or 20 Seconds.
Real time updates of such counters also leads to unnecessary CPU time spent on something that the user won't be able to read anyway. This also means unnecessary power spending. (Of course, both of these things are pretty negligible but real nonetheless)
One last thing real time updates for the counters are bad for is a display with a variable refresh rate. If Video2x runs, e.g. on a laptop display with a variable refresh rate of 30–120 Hz, the display would be forced to update at 120 Hz as long as the Video2x GUI is visible on screen, again wasting power.
My suggestion:
Either update the counters much slower or give the user a setting to choose how fast they want the counters to be updated. That way the user can choose how they want the GUI to behave, which allows them to save some power.
(Also, the FPS counter is very "jumpy" since it can go from "1.5" to "1.49999" every other frame. Maybe show fewer decimal places and/or make all zeros after the decimal point always show up, so it would say "1.50000" instead of "1.5".)
The text was updated successfully, but these errors were encountered: