Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add more models #1231

Open
Senshou opened this issue Nov 18, 2024 · 9 comments
Open

[Feature Request] Add more models #1231

Senshou opened this issue Nov 18, 2024 · 9 comments
Labels
state:Backlog This issue will be worked on in the future type:Enhancement New feature or request

Comments

@Senshou
Copy link

Senshou commented Nov 18, 2024

Hello, i love Video2x, but i think there is few models to upscale different types of footage. Would it possible to add more models, like from openmodeldb.info for example? Thanks in advance!

@github-actions github-actions bot added the state:Backlog This issue will be worked on in the future label Nov 18, 2024
@Senshou Senshou changed the title Add more models [Feature Request] Add more models Nov 18, 2024
@k4yt3x k4yt3x added the type:Enhancement New feature or request label Nov 18, 2024
@k4yt3x
Copy link
Owner

k4yt3x commented Nov 18, 2024

I can probably look into this in the long run. At the moment, it only supports ncnn models at best. It'll be great to be able to support PyTorch and ONNX formats.

@Pete4K
Copy link

Pete4K commented Jan 13, 2025

Is it possible to use these models by xinntao:

These are some of the last models he had created.

@k4yt3x
Copy link
Owner

k4yt3x commented Jan 13, 2025

Yeah I am aware. The current issue is that the PyTorch to ncnn conversion isn't working. If you try the realesrgan-plus-x2 model, it produces black frames.

@Pete4K
Copy link

Pete4K commented Jan 13, 2025

Damn. I would like to train a model, a Combination of Real ESRGAN Animevideo v3 and Real ESRGAN Anime Plus would be great, because Anime Plus is a little too Sharp and too slow at the moment.

@Pete4K
Copy link

Pete4K commented Jan 14, 2025

Could it be possible to change the Real ESRGAN Anime Plus-Model to 2x (as 2nd option to 4x), when you use such a command like xinntao wrote in an issue tab:
"For now, you can use another argument --outscale. For example, you can add --outscale 2 to upsample x2." xinntao/Real-ESRGAN#88

@k4yt3x
Copy link
Owner

k4yt3x commented Jan 14, 2025

@Pete4K I took a look at the code. --outscale seems to be just a lanczos filter:

image

I don't think it's gonna help processing speed?

@Pete4K
Copy link

Pete4K commented Jan 14, 2025

I don't know if that works, because my programming language knowledge is more than worse ;). I think when this would work, you can have a clearer quality with a smaller file size. But I don't know what affects the processing speed. I hope it will be possible in the future. But I don't know this for Anime plus x4, because I saw that this model is trained for anime pictures. But it works totally great for anime and it seems to produce the clearest textures.

@k4yt3x
Copy link
Owner

k4yt3x commented Jan 14, 2025

If we have a 4x model then its output will always be 4x. Doing the rescaling like this actually takes extra time to complete. If you want the output to be smaller, you can rescale it with lanczos yourself after the processing is completed. You're effectively discarding some work and resizing its resolution to a lower one.

I'm working on #1196 which will add support for FFmpeg filters in v2x.

@Pete4K
Copy link

Pete4K commented Jan 14, 2025

That seems to be a great Idea with the Filters. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:Backlog This issue will be worked on in the future type:Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants