Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Lossless encoding #1232

Closed
ShortyCM opened this issue Nov 19, 2024 · 4 comments
Closed

[Feature Request] Lossless encoding #1232

ShortyCM opened this issue Nov 19, 2024 · 4 comments
Labels
state:Done This issue has been resolved/dismissed type:Enhancement New feature or request

Comments

@ShortyCM
Copy link

Being able to use x265 lossless encoding will likely be useful in some cases. This may or may not work:

master...ShortyCM:video2x:master
k4yt3x/video2x-qt6@master...ShortyCM:video2x-qt6:master

I'd test it myself but don't currently have any dev tools installed yet after a recent Windows do-over, and not sure when I'll have time to get all that installed, too.

@github-actions github-actions bot added the state:Backlog This issue will be worked on in the future label Nov 19, 2024
@k4yt3x
Copy link
Owner

k4yt3x commented Nov 20, 2024

I've closed the two PRs for now. I appreciate your work, though I'd like to implement something that's more versatile if anything were to be added. See my comments in the PRs for more detail.

@k4yt3x
Copy link
Owner

k4yt3x commented Nov 22, 2024

Implemented in 3215c89.

You can now specify any AVOptions with --extra-encoder-option, -e. For setting libx265 lossless to 1, do -e x265-params=lossless=1.

image

This will be included in the next release. I'll consider when to add full support of this in the GUI.

@k4yt3x k4yt3x closed this as completed Nov 22, 2024
@github-actions github-actions bot added state:Done This issue has been resolved/dismissed and removed state:Backlog This issue will be worked on in the future labels Nov 22, 2024
@k4yt3x
Copy link
Owner

k4yt3x commented Nov 22, 2024

Another screenshot just to show the currently supported encoder options:

image

@k4yt3x
Copy link
Owner

k4yt3x commented Nov 22, 2024

I'll also leave this here. Full change for this implementation:

https://github.com/k4yt3x/video2x/compare/169509b..HEAD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:Done This issue has been resolved/dismissed type:Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants